-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge/23.9.0.4 into trunk #22319
Merge/23.9.0.4 into trunk #22319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spencertransier for getting ahead on this while I was offline!
Love the power of distributed teams ❤️ 👏 and of teammates that are always happy to help!!!
CI failed with:
|
Notice that the version apparently downgraded from 1.109.3 to 1.109.2. The reason this happened is that we are on a merge branch from the release branch into trunk. The release branch commit from which this branch originated is 22b2216. The latest commit on trunk that was merged into here is 12065e6. At those commits, release/23.9 uses Gutenberg for Mobile Apps (GMA) v1.109.3 while trunk v1.110.0-alpha2. The versioning in GMA works in a way that only updates the version value when a new stable version is shipped. As such, v1.110.0-alpha2 results has having version 1.109.2 as can be seen in the source code at https://github.com/wordpress-mobile/gutenberg-mobile/blob/v1.110.0-alpha2/package.json#L3 Since the version of trunk that was merged in this branch uses v1.110.0-alpha2, the computed version number tracked in `Podfile.lock` is 1.109.2.
Generated by 🚫 dangerJS |
…ller` Possibly a leftover from the merge in 3472aa1 ?
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
😞 there's been a UI test failure on iPhone. Investigating through the |
Okay. Here's what I think happened and why I feel comfortable merging the PR despite of the failure. First of all, the failure was at the time of pressing the "View" button on the "toast" shown after publishing a post. The timeline in the The test didn't fail at that point, though. It tried to hit the button two more times. On the second retry, it waited for the app to become idle for 9 seconds: By that time the idle requirement was met, the toast had disappeared and any further attempt to find the button failed: While it's possible this is an issue introduced by code changes here, it's also clear that the feature is not 5 broken for the users. I also verified that on the TestFlight build. RPReplay_Final1704258378.movAs such, we can merge this and move on with the important localization business. One question is why did the tests wait 9 seconds for the app to idle?! Could that be related to the recap toast fade out? |
This PR merges the changes from the
23.9.0.4
beta build intotrunk
. Includes: