-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gutenberg Video block from excerpt to hide VideoPress URLs #22713
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/WordPress-iOS-Shared#352 (review) (pending the Danger checks succeeding and WordPressShared references updating. 😄)
@@ -23,10 +23,10 @@ workspace 'WordPress.xcworkspace' | |||
## =================================== | |||
## | |||
def wordpress_shared | |||
pod 'WordPressShared', '~> 2.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the last couple of times this reference, which was in #22376 and #20511. From those PRs, I see only the commit hash was updated in the main PR, then apps infra later created a release tag in 7fe3947 and d288944.
@mokagio, is this approach the right one? I've followed that lead with this PR, but would be keen to learn if I should have done something differently here. Thank you!
Fixes the iOS side of wordpress-mobile/gutenberg-mobile#6669
Description
See wordpress-mobile/WordPress-iOS-Shared#352 for more information and testing steps.
Regression Notes:
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: