Enable .com web based login on test builds #23801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23801-e73c44c | |
| Version | 25.4.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e73c44c | |
| App Center Build | WPiOS - One-Offs #11036 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23801-e73c44c | |
| Version | 25.4.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e73c44c | |
| App Center Build | jetpack-installable-builds #10076 |
kean
reviewed
Nov 14, 2024
| @@ -540,6 +540,11 @@ extension WordPressAppDelegate { | |||
| /// Updates the remote feature flags using an authenticated remote if a token is provided or an account exists | |||
| /// Otherwise an anonymous remote will be used | |||
| func updateFeatureFlags(authToken: String? = nil, completion: (() -> Void)? = nil) { | |||
| // Enable certain feature flags on test builds. | |||
| if BuildConfiguration.current ~= [.a8cPrereleaseTesting, .a8cBranchTest, .localDeveloper] { | |||
There was a problem hiding this comment.
Is this change still needed? I saw the message saying that the is no rush. If that's the case, I'd suggest closing this.
There was a problem hiding this comment.
I'm fine with closing this PR. The tricky thing about this particular feature flag is it's on the main login page, where you don't have access to the Debug menu. There is no convenient way to enable the feature flag during testing, without signing into the app first.
There was a problem hiding this comment.
It's up to you. I'm going to approve.
kean
approved these changes
Nov 15, 2024
| @@ -540,6 +540,11 @@ extension WordPressAppDelegate { | |||
| /// Updates the remote feature flags using an authenticated remote if a token is provided or an account exists | |||
| /// Otherwise an anonymous remote will be used | |||
| func updateFeatureFlags(authToken: String? = nil, completion: (() -> Void)? = nil) { | |||
| // Enable certain feature flags on test builds. | |||
| if BuildConfiguration.current ~= [.a8cPrereleaseTesting, .a8cBranchTest, .localDeveloper] { | |||
There was a problem hiding this comment.
It's up to you. I'm going to approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dotComWebLoginis still in 10% roll out at the moment. Enabling it in test builds would make it easier for others to try the new flow.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: