Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transitions in Blogging Reminders flow, improve accessibility, add close buttons #23931

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 31, 2024

Changes:

  • Remove BottomSheetViewController usage from BloggingReminders flow. It now uses modern deters for the intro screen and standard modal flows for the rest of the flow, so there is no jumping.
  • Remove FancyButton usages
  • Add UIButton.Configuration based .primary button style
  • Improve accessibility in the flow (close buttons, better dynamic type support)
  • This PR also adds a couple of convenience APIs: SpacerView, SeparatorView, BottomToolbarView
  • Remove unused LightNavigationController

Accessibility

The intro screen can now accommodate larger font sizes. It also has a "close" button, so does the "Settings" screen.

Screen.Recording.2024-12-31.at.2.16.30.PM.mov
Screenshot 2024-12-31 at 2 14 23 PM

Animations

It also no longer has these broken transitions (it just shows a standard form instead)

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-30.at.18.14.26.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.7 milestone Dec 31, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 31, 2024

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kean kean changed the base branch from trunk to christmas-feature-branch December 31, 2024 20:20
@kean kean merged commit 27e19ee into christmas-feature-branch Dec 31, 2024
5 of 20 checks passed
@kean kean deleted the task/remove-bottom-sheet-vc-2314jfe-0wjf branch December 31, 2024 20:22
@kean kean changed the title Enhance BloggingRemindersFlow Fix transitions in Blogging Reminders flow, improve accessibiliy, add close buttons Dec 31, 2024
@kean kean changed the title Fix transitions in Blogging Reminders flow, improve accessibiliy, add close buttons Fix transitions in Blogging Reminders flow, improve accessibility, add close buttons Dec 31, 2024
@kean kean mentioned this pull request Dec 31, 2024
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23931-84ac565
Version25.6
Bundle IDorg.wordpress.alpha
Commit84ac565
App Center BuildWPiOS - One-Offs #11240
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23931-84ac565
Version25.6
Bundle IDcom.jetpack.alpha
Commit84ac565
App Center Buildjetpack-installable-builds #10278
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants