-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Share action to site link context menu on dashboard #23935
Conversation
cc8e863
to
4c26d71
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
@@ -108,7 +108,7 @@ private enum MenuItem { | |||
var title: String { | |||
switch self { | |||
case .visitSite: return Strings.visitSite | |||
case .shareSite: return Strings.shareSite | |||
case .shareSite: return SharedStrings.Button.share + "…" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add "..." here? I don't think other Share buttons have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I added it because the default UITextView
also does it for URLs. I'm not sure what's the reasoning though. I removed it in #23975.
Changes:
SharedStrings.Button.*
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: