Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup MediaHost initializers #23939

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Cleanup MediaHost initializers #23939

merged 3 commits into from
Jan 2, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 2, 2025

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Media label Jan 2, 2025
@kean kean added this to the 25.7 milestone Jan 2, 2025
kean
kean commented Jan 2, 2025
View reviewed changes
WordPress/Classes/Models/WPAccount+Lookup.swift
@@ -47,6 +47,7 @@ public extension WPAccount {
///
static func lookup(withUUIDString uuidString: String, in context: NSManagedObjectContext) throws -> WPAccount? {
let fetchRequest = NSFetchRequest<Self>(entityName: WPAccount.entityName())
fetchRequest.fetchLimit = 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimizes this query a bit.

WordPress/WordPressTest/MediaHostTests.swift
@@ -1,5 +1,5 @@
import Testing
import WordPressMedia
@testable import WordPress
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes tests.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@kean kean merged commit 221386f into christmas-feature-branch Jan 2, 2025
5 of 21 checks passed
@kean kean deleted the task/simplify-media-host branch January 2, 2025 23:53
@kean kean mentioned this pull request Jan 2, 2025
Merged
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23939-ebbeb8b
Version25.6
Bundle IDorg.wordpress.alpha
Commitebbeb8b
App Center BuildWPiOS - One-Offs #11257
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23939-ebbeb8b
Version25.6
Bundle IDcom.jetpack.alpha
Commitebbeb8b
App Center Buildjetpack-installable-builds #10294
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Media
Projects
None yet
Milestone
25.7
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @dangermattic @wpmobilebot