Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with clear navigation bar background in revision browser #23941

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 3, 2025

Changes:

  • Fix an issue with clear navigation bar background in revision browser
  • Show "Close" button instead of "Done" (odd location for done on the left)
  • Modernize the "More" menu by using UIMenu
  • Fix the safe are insets for the toolbar

Before / After

Screenshot 2025-01-03 at 9 03 23 AM Screenshot 2025-01-03 at 9 55 29 AM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23941-eab7835
Version25.6
Bundle IDcom.jetpack.alpha
Commiteab7835
App Center Buildjetpack-installable-builds #10301
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23941-eab7835
Version25.6
Bundle IDorg.wordpress.alpha
Commiteab7835
App Center BuildWPiOS - One-Offs #11264
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this to the 25.7 milestone Jan 3, 2025
@kean kean changed the base branch from trunk to christmas-feature-branch January 3, 2025 14:57
@kean kean mentioned this pull request Jan 3, 2025
14 tasks
@kean kean merged commit 87ff4b6 into christmas-feature-branch Jan 3, 2025
17 of 26 checks passed
@kean kean deleted the fix/clear-background-revision-browser branch January 3, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants