Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tint color in wpios #23946

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix tint color in wpios #23946

merged 2 commits into from
Jan 6, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 6, 2025

At some point when introducing new colors, wpios was updated to use .brand instead of .primary, which is incorrect.

Screenshot 2025-01-06 at 12 55 47 PM

This PR fixes the primary tint color and also removes .brand entirely to avoid any confusion in the future. The new blue color also uses a slightly lighter shade in dark mode – just like we do in jpios. The previous town was too dark.

Before

Screenshot 2025-01-06 at 12 55 11 PM Screenshot 2025-01-06 at 12 55 06 PM

After

Screenshot 2025-01-06 at 1 00 19 PM Screenshot 2025-01-06 at 1 28 30 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Jan 6, 2025
@kean kean added this to the 25.7 milestone Jan 6, 2025
@kean kean merged commit 2dbd0fc into christmas-feature-branch Jan 6, 2025
2 of 4 checks passed
@kean kean deleted the fix/tint-color-wpios branch January 6, 2025 18:30
@kean kean mentioned this pull request Jan 6, 2025
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23946-ff83911
Version25.6
Bundle IDorg.wordpress.alpha
Commitff83911
App Center BuildWPiOS - One-Offs #11277
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23946-ff83911
Version25.6
Bundle IDcom.jetpack.alpha
Commitff83911
App Center Buildjetpack-installable-builds #10314
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants