Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update AutomatticAbout #23963

Merged
merged 1 commit into from
Jan 23, 2025
Merged

build: Update AutomatticAbout #23963

merged 1 commit into from
Jan 23, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 9, 2025

Warning

The public launch date for the Woo 2.0 Brand Rollout project is Feb 4th. ⚠️ So, this change should not be released earlier or later. Since we release apps weekly or bi-weekly, please target the week of Feb 4th, If that’s not feasible, the following week.

Include the latest Woo branding. Relates to pbMoDN-4vZ-p2.

To test:

  1. Navigate to MeAbout Jetpack for iOS.
  2. Verify the new logo is displayed for the Woo marble.
Light Dark
Simulator Screenshot - iPhone 16 Pro - 2025-01-09 at 10 38 17 Simulator Screenshot - iPhone 16 Pro - 2025-01-09 at 10 38 26

Regression Notes

  1. Potential unintended areas of impact
    None, unlikely for this single dependency update.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 9, 2025

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

@kean kean changed the base branch from trunk to christmas-feature-branch January 9, 2025 15:51
@kean kean changed the base branch from christmas-feature-branch to trunk January 9, 2025 15:52
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 9, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23963-c10a385
Version25.7
Bundle IDorg.wordpress.alpha
Commitc10a385
App Center BuildWPiOS - One-Offs #11390
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 9, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23963-c10a385
Version25.7
Bundle IDcom.jetpack.alpha
Commitc10a385
App Center Buildjetpack-installable-builds #10422
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@oguzkocer oguzkocer added this to the 25.7 milestone Jan 22, 2025
@dcalhoun dcalhoun force-pushed the build/update-automattic-about branch from 67dbdd8 to b995de0 Compare January 22, 2025 21:06
@wpmobilebot wpmobilebot modified the milestones: 25.7, 25.8 Jan 22, 2025
@wpmobilebot
Copy link
Contributor

Version 25.7 has now entered code-freeze, so the milestone of this PR has been updated to 25.8.

Include the latest Woo branding.
@dcalhoun dcalhoun force-pushed the build/update-automattic-about branch from b995de0 to c10a385 Compare January 23, 2025 13:05
@dcalhoun dcalhoun marked this pull request as ready for review January 23, 2025 13:06
@dcalhoun dcalhoun requested a review from kean January 23, 2025 13:06
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 25.7 release branch is cut, so it seems like a good time to merge 👍

@dcalhoun dcalhoun added this pull request to the merge queue Jan 23, 2025
Merged via the queue into trunk with commit 9ffb37a Jan 23, 2025
26 checks passed
@dcalhoun dcalhoun deleted the build/update-automattic-about branch January 23, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants