Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BlockPicker to gutenberg as Inserter in @wordpress/block-editor #1122

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Move BlockPicker to gutenberg as Inserter in @wordpress/block-editor #1122

merged 2 commits into from
Jun 13, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 12, 2019 •
edited
Loading

Step 3 of #958
This is the next step in our port of the BlockList to gutenberg.

Gutenberg PR: WordPress/gutenberg#16114

Testing Instructions

  • Boot the app on iOS and Android
  • Check that the block picker still works as expected

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@Tug Tug added this to the v1.8 milestone Jun 12, 2019
@Tug Tug self-assigned this Jun 12, 2019
@Tug Tug mentioned this pull request Jun 12, 2019
Merged
5 tasks
@Tug Tug requested review from etoledom and mzorz June 12, 2019 12:37
@Tug Tug added [Type] Enhancement Improves a current area of the editor and removed [Status] Not Ready For Review labels Jun 12, 2019
@Tug Tug requested a review from koke June 12, 2019 12:38
etoledom
etoledom approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#16114 (review)

Thank you @Tug ! Great gob

@Tug Tug merged commit e24c2fd into develop Jun 13, 2019
@Tug Tug deleted the update/move-picker-to-wordpress-block-editor branch June 13, 2019 11:45
@koke koke mentioned this pull request Jun 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@mzorz mzorz Awaiting requested review from mzorz

@koke koke Awaiting requested review from koke

Assignees

@Tug Tug

Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @etoledom