Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract caption component #1254

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Extract caption component #1254

merged 2 commits into from
Aug 20, 2019

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 30, 2019 •
edited
Loading

This PR extract caption from image block to be shared with video block. This ports over both rich text styling and a keyboard-dismissal bug fix to the video block. It also adds the ability to select the video block when the video block's caption is selected without playing the video.

Further details and testing instructions are in the related gutenberg PR.

There are user facing changes, so I have added an item to RELEASE-NOTES.txt.

@mchowning mchowning mentioned this pull request Jul 30, 2019
Merged
@mchowning mchowning self-assigned this Jul 31, 2019
@mchowning
Copy link
Contributor Author

mchowning commented Jul 31, 2019 •
edited
Loading

Labeling this as not ready for review while I dig into the test failures

@mchowning mchowning force-pushed the extract_caption_component branch from 0dbdbbb to d13977b Compare July 31, 2019 21:09
@mchowning mchowning requested a review from Tug July 31, 2019 21:10
@mchowning mchowning added this to the 1.11 milestone Jul 31, 2019
@etoledom
Copy link
Contributor

etoledom commented Aug 2, 2019

Hey @mchowning !
I try to update the submodule but I get an error:

❯❯❯ git submodule update
error: Server does not allow request for unadvertised object 7f487d33f6e498a88e7230dba390638b4b93e570
Fetched in submodule path 'gutenberg', but it did not contain 7f487d33f6e498a88e7230dba390638b4b93e570. Direct fetching of that commit failed.

Maybe you haven't push the last commit to the gutenberg repo?

@mchowning mchowning force-pushed the extract_caption_component branch from d13977b to 8b2363a Compare August 2, 2019 10:52
@mchowning
Copy link
Contributor Author

mchowning commented Aug 2, 2019 •
edited
Loading

I try to update the submodule but I get an error... Maybe you haven't push the last commit to the gutenberg repo?

👋 @etoledom ! So sorry about that. Actually, It was this repo that I forgot to update 🙁 and because I force-pushed over 7f487d3 in gutenberg, that commit got gc'd (explains why the gutenberg-mobile build was able to pull 7f487d3 2 days ago but it's gone now).

@mchowning mchowning force-pushed the extract_caption_component branch from 8b2363a to e1308eb Compare August 8, 2019 12:40
etoledom
etoledom approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Tested via WordPress/gutenberg#16825 (review)

@mchowning mchowning force-pushed the extract_caption_component branch 3 times, most recently from b1bd0cc to 9f0b48b Compare August 9, 2019 00:03
@mchowning mchowning force-pushed the extract_caption_component branch from 9f0b48b to 19c52ab Compare August 20, 2019 12:30
@mchowning mchowning merged commit d8aeb9b into develop Aug 20, 2019
@mchowning mchowning deleted the extract_caption_component branch August 20, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@Tug Tug Awaiting requested review from Tug

Assignees

@mchowning mchowning

Labels
None yet
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @etoledom