Port Quote block step 1 #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…g-mobile into port-quote-block-step-1 * 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: (27 commits) Point to latest from RecyclerViewList Point to latest react-native-aztec Adding yarn.lock field for `turbo-combine-reducers`. Added turbo-combine-reducers dependency to fix failed builds Update subrepo ref to point to master again Update subrepo ref No need for change of default Jest platform Update subrepo ref Update subrepo ref Fix lint warnings Mocking `react-native-gutenberg-bridge` to make iOS tests pass. From: jestjs/jest#2208 (comment) rn-gutenberg-bridge: Adding dumb iOS implementation to avoid errors. Revert "Update gutenberg subproject ref" Add react-native-hr library to add styled line+text elements easily Update gutenberg subproject ref Match wpandroid's Android API levels Remove plugin from Babel to make wpandroid release build work Fix wpandroid checkstyle issues Remove dep, Matro will find the package automagically Fix indentation ... # Conflicts: # gutenberg
|
I've changed the target branch to |
|
This PR is very old, and we've recently agreed to re-use much of the web code as possible when porting new blocks to mobile. Experimenting this new way in the List block here: WordPress/gutenberg#14249 Also the GB side of this PR was already closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a very basic initial support for quote blocks.
GB side PR:
How has this been tested?
There are still things need to be addressed, like adding the ability to create a block from toolbar.
Also the ability to add/remove the
citepart is missing, as well as basic interactions "within" the block: move the cursor up/down between those 2 editors.Gutenberg Side PR: WordPress/gutenberg#11311