Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing UI test for File block #2835

Merged
merged 29 commits into from
Dec 4, 2020
Merged

Implementing UI test for File block #2835

merged 29 commits into from
Dec 4, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Nov 24, 2020 •
edited
Loading

gutenberg PR: WordPress/gutenberg#27228
WPiOS PR: wordpress-mobile/WordPress-iOS#15400
WPAndroid PR: wordpress-mobile/WordPress-Android#13482

This PR updates the gutenberg reference to test the new canary UI tests for the File block.

Note:

  • For the tests to pass, it was needed to enable the File block in prod build. So, this PR should be the last one to be merged.
  • To test inserting a file block, we need the WPMediaLibrary PRs to be merged first.

To test:

  • CI must be ✅
  • Manual tests from WPiOS and WPAndroid PRs should be ✅

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Testing Anything related to automated tests label Nov 24, 2020
@etoledom etoledom added this to the 1.43 (16.4) milestone Nov 24, 2020
@etoledom etoledom self-assigned this Nov 24, 2020
@etoledom etoledom mentioned this pull request Nov 24, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@etoledom etoledom marked this pull request as ready for review November 26, 2020 15:46
@etoledom etoledom mentioned this pull request Nov 27, 2020
Closed
2 tasks
jd-alexander
jd-alexander approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom the bundle update needs to happen here again. Apart from that, I think we are good to go so I am approving this PR. You can do your final checks.

@etoledom etoledom changed the title [Do not merge] Implementing UI test for File block Implementing UI test for File block Dec 4, 2020
@etoledom etoledom merged commit b69a231 into develop Dec 4, 2020
@etoledom etoledom deleted the rnmobile/file-block-VI-ui-tests branch December 4, 2020 21:39
@guarani guarani mentioned this pull request Dec 8, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-alexander jd-alexander jd-alexander approved these changes

Assignees

@etoledom etoledom

Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
1.43 (16.4)
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @jd-alexander