Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat a string that only contains the formatting marker as empty for block formatting #2877

Closed
wants to merge 4 commits into from

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Dec 8, 2020

Fixes #2863

Related PRs

To test:

Existing Block

  1. Open a post with an existing Heading Block
  2. Select the text and hit delete
    • Alternatively, delete each character one by one
  3. Expect to see the placeholder text return after the last character is deleted and for the block to remain

New Heading Block

  1. Open a post and add a new heading block
  2. Type some text
    • Expect The text to be formatted like a heading block
  3. Select the text and hit delete
    • Alternatively, delete each character one by one
  4. Expect to see the placeholder text return after the last character is deleted and for the block to remain

Regression test cases

Taken from wordpress-mobile/AztecEditor-Android#928

Regression test cases

Heading block

  1. Open the Gutenberg Editor
  2. Create a Heading block containing some text
  3. Press backspace until all of the text has been deleted
    Expect to see the placeholder text return after the last character is deleted

Paragraph block

  1. Open the Gutenberg Editor
  2. Create a Paragraph block containing some text
  3. Select the full text and apply some styling like bold
  4. Press backspace until all of the text has been deleted
    Expect to see the placeholder text return after the last character is deleted

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the 1.43 (16.4) milestone Dec 8, 2020
@chipsnyder chipsnyder requested review from antonis and geriux December 8, 2020 17:25
@chipsnyder chipsnyder changed the base branch from develop to release/1.43.0 December 8, 2020 17:25
@chipsnyder chipsnyder mentioned this pull request Dec 8, 2020
3 tasks
@chipsnyder chipsnyder force-pushed the rnmobile/2863-headingFormat branch from ae5b47e to a440841 Compare December 8, 2020 17:28
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chipsnyder chipsnyder changed the base branch from release/1.43.0 to develop December 8, 2020 19:27
@chipsnyder chipsnyder force-pushed the rnmobile/2863-headingFormat branch from a440841 to c06bd05 Compare December 8, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants