Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection errors causing failed jobs on CircleCI #4123

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Oct 14, 2021

This aims to fix errors we're seeing similar to Error: Failed to download resource "nghttp2" and ssh: connect to host github.com port 22: Operation timed out.

Running brew update was the suggested fix here and here for similar-sounding issues.

As @dcalhoun noted, #2860 updated curl but also added HOMEBREW_NO_AUTO_UPDATE=1 which prevents brew from updating when curl is installed. To try to determine if this change will cause a performance issue, the job was ran twice and both times it finished in a "normal" duration (20 to 30 minutes).

To test

Check if all CI tests pass (especially Test iOS on Device - CanariesUpload .app to sauce labs).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This aims to fix errors we're seeing similar to `Error: Failed to download resource "nghttp2"`
@guarani guarani marked this pull request as ready for review October 14, 2021 16:44
@guarani guarani requested a review from dcalhoun October 14, 2021 17:49
@guarani guarani added the Testing Anything related to automated tests label Oct 14, 2021
@guarani guarani changed the title Try: Allow brew to update while installing curl Fix connection errors causing failed jobs on CircleCI Oct 14, 2021
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll see if any degradations come after this change, but I think it is worth a try for now.

@guarani
Copy link
Contributor Author

guarani commented Oct 14, 2021

LGTM. We'll see if any degradations come after this change, but I think it is worth a try for now.

Thanks @dcalhoun! I'll try to keep an eye out too.

@guarani guarani merged commit 1863587 into develop Oct 14, 2021
@guarani guarani deleted the try/update-homebrew branch October 14, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants