Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable access to block settings within UBE #5508

Merged
merged 7 commits into from
Mar 1, 2023
Merged

fix: Enable access to block settings within UBE #5508

merged 7 commits into from
Mar 1, 2023

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 24, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun self-assigned this Feb 24, 2023
@dcalhoun dcalhoun added this to the 1.89.1 (21.8) milestone Feb 24, 2023
@dcalhoun dcalhoun added [Type] Regression Existing functionality that got broken Unsupported Block Editor labels Feb 24, 2023
@dcalhoun dcalhoun mentioned this pull request Feb 24, 2023
Merged
@dcalhoun dcalhoun requested a review from geriux February 24, 2023 22:23
@geriux
Copy link
Contributor

geriux commented Feb 28, 2023 •
edited
Loading

Unsupported Block Tests (Android)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Unsupported Block Tests (iOS)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Blocks settings unavailable within the Unsupported Block Editor

  • Simple WP.com sites
  • Atomic sites
  • Self-hosted sites accessed via Jetpack
    🔴 For both iOS and Android the Sidebar button is not visible This only happened with the Table block, so let's not block this.

Unsupported block: Post title is displayed in UBE (Unsupported block editor) when editing an unsupported block

  • Simple WP.com sites
  • Atomic sites
  • Self-hosted sites accessed via Jetpack

Fix UBE Text Selection Bug on Android

  • Simple WP.com sites
  • Atomic sites
  • Self-hosted sites accessed via Jetpack

geriux
geriux approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#48435 (review)

@dcalhoun dcalhoun merged commit 5b6765f into trunk Mar 1, 2023
@dcalhoun dcalhoun deleted the version-toolkit/gutenberg/fix/enable-access-to-block-settings-within-ube branch March 1, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@dcalhoun dcalhoun

Labels
[Type] Regression Existing functionality that got broken Unsupported Block Editor
Projects
None yet
Milestone
1.89.1 (21.8)
Development

Successfully merging this pull request may close these issues.
3 participants
@wpmobilebot @geriux @dcalhoun