Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch account cache updates into one call #173

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

nathanleclaire
Copy link
Contributor

Closes #118

Instead of tons of getAccountInfo calls from the individual components, this PR rolls up the call to refresh top account info into just one getMultipleAccountInfo()

no_more_mainnet_ban_yay.mov

Can haz no more highnet ban?

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@nathanleclaire
Copy link
Contributor Author

nathanleclaire commented Jul 6, 2022

pffft, looks like sol amount likes to wink in and out on faved accounts at the moment

Screen Shot 2022-07-06 at 3 03 36 PM

Screen Shot 2022-07-06 at 3 03 19 PM

that's the only remaining bug i can spot though, this is ready for review

Signed-off-by: Nathan LeClaire <[email protected]>
@SvenDowideit
Copy link
Member

yup, that's got to do with something in the "Max delta" and Count calculation and value saving - its most obvious sorting by Count, as the value never gets above 1

DEFER to next PR

Copy link
Member

@SvenDowideit SvenDowideit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workbench spams getAccountInfo in higher environments
2 participants