Airdrop SOL automatically to wallets #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
nathanleclaire
force-pushed
the
auto_airdrop
branch
from
223ed0f to
3a0006a
Compare
Signed-off-by: Nathan LeClaire <[email protected]>
nathanleclaire
force-pushed
the
auto_airdrop
branch
from
3a0006a to
4095c8d
Compare
| let amount = 0; | ||
|
|
||
| // arbitrary -- want to let people top up | ||
| // on devnet SOL when they can |
There was a problem hiding this comment.
these should all be in the settings dialog (in a future release)
| } | ||
| }; | ||
| airdropIfNeeded(); | ||
| }, [net, wallet.publicKey, validator]); |
There was a problem hiding this comment.
So this will happen once per change of network connection / wallet? (and so if at that point the network was offline, we won't try again?
There was a problem hiding this comment.
Yea. And validator status. So if a brand new local validator starts up without airdrop, it will airdrop again. Was quick to implement and felt a bit less aggressive than polling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Closes #222
Going to hold off on saying #181 is resolved, because I couldn't figure out a way to get the adapter to go ahead and automatically use the electron storage one. Do you know any way?
Doesn't cover config item to not do this, how bad do you want that in 0.4.0?