Nav/try out themeing #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenDowideit
force-pushed
the
nav/try-out-themeing
branch
from
5a2cacb to
be5018b
Compare
nathanleclaire
approved these changes
Mar 21, 2022
|
Whoops, meant to "request changes". At any rate, looks pretty good, just a few comments to take care of then good to go. |
SvenDowideit
force-pushed
the
nav/try-out-themeing
branch
3 times, most recently
from
8272748 to
c871d9d
Compare
nathanleclaire
requested changes
Mar 22, 2022
Signed-off-by: Sven Dowideit <[email protected]>
…ious, and figure out PropTypes for faIcons Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
nav/try-out-themeing
branch
from
e796e8c to
506761c
Compare
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
commented
Mar 23, 2022
src/renderer/App.tsx
Outdated
| style={{ maxHeight: '100px' }} | ||
| navbarScroll | ||
| > | ||
| {/* <TooltipNavItem |
There was a problem hiding this comment.
I'd like to leave this in for a bit while i contemplate the topbar
and extracting these Nav components into another component may make sense, but i'm not ready to do it in this PR - it depends..
Signed-off-by: Sven Dowideit <[email protected]>
|
ok, this one's weird - |
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
|
🎊 |
nathanleclaire
pushed a commit
that referenced
this pull request
Mar 31, 2022
* Separate out less used analytics html * use bootswatch for css, and replace lots of inline html with React components * bring back the icons * rejig the module deps so it works * give us a little padding from the navbar Signed-off-by: Sven Dowideit <[email protected]> * use TooltipNavItem for top and sidebar, change theme to something serious, and figure out PropTypes for faIcons Signed-off-by: Sven Dowideit <[email protected]> * build debug info Signed-off-by: Sven Dowideit <[email protected]> * remove commented out css Signed-off-by: Sven Dowideit <[email protected]> * get rid of the react-table - its abandoned, and makes mpn problems Signed-off-by: Sven Dowideit <[email protected]> * One day, I'll be sure which I need * reapply lit fixes Signed-off-by: Sven Dowideit <[email protected]> * f Signed-off-by: Sven Dowideit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two things I worked on at the same time - simplify the inline html by using bootstrap components, and add https://bootswatch.com/ stylin - I'm using sandstone atm.
I'm most interested in the components use, but adding the themeing showed up how some of the html wasn't actually bootstrap "right", so it was worth it from there too.
There's more stuff to do, but even this helps get us further to where we want to go.