-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yell about TypeScript errors more aggressively #76
Conversation
Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
@@ -1,2 +0,0 @@ | |||
declare module 'randomart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a weird one, originally I had to add these to get TS compiler to stop complaining that types couldn't be found for these modules, but then it started complaining again for some reason despite the existence of this file when I removed the transpile only false settings. 🤷
It works and we're looking to rm these modules anyway so I'm rolling with the switch to require
for now
Signed-off-by: Nathan LeClaire <[email protected]>
@@ -149,30 +149,29 @@ | |||
] | |||
}, | |||
"devDependencies": { | |||
"@pmmmwh/react-refresh-webpack-plugin": "0.5.4", | |||
"@solana/web3.js": "^1.31.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bleh, these changes are more far-reaching than I intended, sorry. npm install --save-dev
for a new @types
file that the CI was breaking due to not having ended up making all these changes.
lets see what
ok, now to try again on my local box. |
ok, succeeds on local new clone - so its something-something out of sync (DEFER fixing that) |
ok, so the expected effect is that the Hopefully there's a way to make them also surface in LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #75