Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yell about TypeScript errors more aggressively #76

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

nathanleclaire
Copy link
Contributor

Fixes #75

Signed-off-by: Nathan LeClaire <[email protected]>
Signed-off-by: Nathan LeClaire <[email protected]>
@@ -1,2 +0,0 @@
declare module 'randomart';
Copy link
Contributor Author

@nathanleclaire nathanleclaire Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a weird one, originally I had to add these to get TS compiler to stop complaining that types couldn't be found for these modules, but then it started complaining again for some reason despite the existence of this file when I removed the transpile only false settings. 🤷

It works and we're looking to rm these modules anyway so I'm rolling with the switch to require for now

Signed-off-by: Nathan LeClaire <[email protected]>
@@ -149,30 +149,29 @@
]
},
"devDependencies": {
"@pmmmwh/react-refresh-webpack-plugin": "0.5.4",
"@solana/web3.js": "^1.31.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, these changes are more far-reaching than I intended, sorry. npm install --save-dev for a new @types file that the CI was breaking due to not having ended up making all these changes.

@SvenDowideit
Copy link
Member

SvenDowideit commented Apr 6, 2022

lets see what docker build . does for me:

Step 12/17 : RUN source /root/.profile && source $HOME/.nvm/nvm.sh     && npm install --legacy-peer-deps
 ---> Running in 06c6c8231ddd



npm WARN deprecated [email protected]: CircularJSON is in maintenance only, flatted is its successor.
npm WARN deprecated [email protected]: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated @types/[email protected]: This is a stub types definition. terser-webpack-plugin provides its own type definitions, so you do not need this installed.
npm notice 
npm notice New minor version of npm available! 8.3.1 -> 8.6.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
npm notice Run `npm install -g [email protected]` to update!
npm notice 
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! network Socket timeout
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-04-06T01_14_53_592Z-debug-0.log

ok, now to try again on my local box.

@SvenDowideit
Copy link
Member

ok, succeeds on local new clone - so its something-something out of sync (DEFER fixing that)

@SvenDowideit
Copy link
Member

ok, so the expected effect is that the npm exec tsc errors will now also be shown in npm start - no change to npm run lint.

Hopefully there's a way to make them also surface in npm run build (it doesn't seem to happen for me atm)

LGTM

Copy link
Member

@SvenDowideit SvenDowideit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SvenDowideit SvenDowideit merged commit 94fb2fc into main Apr 6, 2022
@SvenDowideit SvenDowideit deleted the yell_about_ts_errors_more_aggressively branch April 6, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants