Fix/dont make requests when validator offline (and use electron-log in the renderer) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good, |
|
its "just" one of the built in levels - see "Log Levels" in https://www.npmjs.com/package/electron-log |
SvenDowideit
force-pushed
the
fix/dont-make-requests-when-validator-offline
branch
from
aec5b79 to
80146e7
Compare
SvenDowideit
changed the title
|
very cool... after conflicts fixed, LGTM |
nathanleclaire
approved these changes
May 4, 2022
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
…not running Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
fix/dont-make-requests-when-validator-offline
branch
from
74af653 to
6fa4188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of ws and POST console logs that come from inside nested 4th party modules that show we're making requests even when we know there's no point
this gates them based on NetStatus, and replaces console.log with logger.info