Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yichen1 ai 5172 refactor hd matching #63

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

ycbiometrics
Copy link
Contributor

{{Pull Request name here}}

PR description

add m_gradient as a parameter to matcher, which can be tuned based on iriscode size when normalized HD is enabled.

Issue

Solution

Limitations

Type

  • Feature
  • Refactoring
  • Bugfix
  • DevOps
  • Testing

Checklist

  • I've made sure that my code works as expected by writing unit tests.
  • I've checked if my code doesn't generate warnings or errors.
  • I've performed a self-review of my code.
  • I've made sure that my code follows the style guidelines of the project.
  • I've commented hard-to-understand parts of my code.
  • I've made appropriate changes in the documentation.

@ycbiometrics ycbiometrics requested a review from a team as a code owner January 28, 2025 22:11
@ycbiometrics ycbiometrics changed the base branch from main to dev January 29, 2025 01:59
Copy link
Member

@wiktorlazarski wiktorlazarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycbiometrics ycbiometrics merged commit 6f9ae8d into dev Jan 29, 2025
8 checks passed
@ycbiometrics ycbiometrics deleted the yichen1-ai-5172-refactor-hd-matching branch January 29, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants