Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Route enum; enable route plugins #2412

Conversation

artursapek
Copy link
Collaborator

@artursapek artursapek commented Aug 20, 2024

  • Removes Route enum type in Connect,
    • Makes it possible to add arbitrary SDKv2 routes that Connect doesn't know about
  • Changes WormholeConnectConfig interface to accept an array of SDKv2 RouteConstructors
  • Changes RouteOperator to be stateful, not a global singleton class
  • Removes proxy pass-through methods from RouteOperator

Copy link

netlify bot commented Aug 20, 2024

👷 Deploy request for wormhole-connect pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e7aa69c

Copy link

netlify bot commented Aug 20, 2024

👷 Deploy request for wormhole-connect-mainnet pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e7aa69c

@artursapek artursapek force-pushed the remove-route-enum branch 3 times, most recently from 0ba2ff0 to 73752dc Compare August 21, 2024 16:19
Copy link

socket-security bot commented Aug 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@artursapek/[email protected] environment, network Transitive: filesystem, shell +13 1.4 MB artursapek

View full report↗︎

@artursapek artursapek marked this pull request as ready for review August 22, 2024 00:47
@nikarm22 nikarm22 mentioned this pull request Aug 22, 2024
kev1n-peters
kev1n-peters previously approved these changes Aug 22, 2024
@kev1n-peters kev1n-peters merged commit 0e7e459 into wormhole-foundation:development Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants