Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Connect docs - transactionSettings and disableUserInputtedTokens #218

Merged
merged 15 commits into from
Feb 4, 2025
Merged

Updates to Connect docs - transactionSettings and disableUserInputtedTokens #218

merged 15 commits into from
Feb 4, 2025

Conversation

artursapek
Copy link
Contributor

No description provided.

@artursapek artursapek changed the title WIP: updates to Connect docs (tx settings) Updates to Connect docs - transactionSettings and disableUserInputtedTokens Jan 27, 2025
@artursapek artursapek marked this pull request as ready for review January 27, 2025 19:41
@eshaben eshaben requested a review from ilariae January 28, 2025 07:25
@eshaben eshaben added B0 - Needs Review Pull request is ready for review A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) C2 - High High priority task labels Jan 28, 2025
ilariae
ilariae previously approved these changes Feb 3, 2025
View reviewed changes
eshaben
eshaben reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ilariae - I know I said this was already good. Content does look good, but I happened to notice a couple more things 😬

build/applications/connect/configuration/configure-data.md Outdated Show resolved Hide resolved
.snippets/code/build/applications/connect/configuration/custom-tokens-whitelist-advanced.jsx Outdated Show resolved Hide resolved
.snippets/code/build/applications/connect/configuration/custom-tx-settings-solana.jsx Outdated Show resolved Hide resolved
.snippets/code/build/applications/connect/configuration/custom-tx-settings-solana.jsx Outdated Show resolved Hide resolved
.snippets/code/build/applications/connect/configuration/custom-tx-settings-solana.jsx Outdated Show resolved Hide resolved
.snippets/code/build/applications/connect/configuration/custom-tx-settings-solana.jsx Outdated Show resolved Hide resolved
build/applications/connect/configuration/configure-data.md Show resolved Hide resolved
@artursapek @eshaben
Update configure-data.md
a879f7c 
Co-authored-by: Erin Shaben <[email protected]>
@ilariae ilariae requested a review from eshaben February 4, 2025 15:03
@eshaben eshaben removed the B0 - Needs Review Pull request is ready for review label Feb 4, 2025
@eshaben eshaben added the B1 - Ready to Merge Pull request is ready to be merged label Feb 4, 2025
@ilariae ilariae merged commit 27ff1c6 into wormhole-foundation:main Feb 4, 2025
1 check passed
This was referenced Feb 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@ilariae ilariae ilariae left review comments

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09 dawnkelly09 is a code owner

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged C2 - High High priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artursapek @eshaben @ilariae