Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: true zero-downtime deployment with request draining #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wowu
Copy link
Owner

@wowu wowu commented Nov 3, 2024

Changes:

  • Add --pre-stop-hook argument.
  • Describe in README how to setup a true zero-downtime deployment.

Notes:

  • Hook name "pre-stop" (instead of "before-stop") is inspired by watchtower hooks. This way other hooks can be named "post-stop" etc
  • I decided not to add other hooks yet - we will add them when somebody reports a need with a valid use case
  • I think it's better to implement draining with an explicitly written command in a hook, rather than a flag like --drain with the same implementation, so users can actually understand the process

Close #21, #32.

@wowu wowu mentioned this pull request Nov 3, 2024
@wowu wowu marked this pull request as ready for review November 3, 2024 14:17
@akoenig
Copy link

akoenig commented Nov 18, 2024

Thanks, @wowu. This looks fantastic! I'm looking forward to the rollout of this feature. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

True zero-downtime deployment by request draining
2 participants