Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings for more scenarios #61

Closed
swissspidy opened this issue Jul 29, 2018 · 1 comment
Closed

Add warnings for more scenarios #61

swissspidy opened this issue Jul 29, 2018 · 1 comment

Comments

@swissspidy
Copy link
Member

Previously: #33.


The WordPress Coding Standards project has a few sniffs that we could borrow from to improve the warnings created by the make-pot command.

These sniffs currently do:

  • Check for the presence of a translators comment if one of the text strings contains a placeholder.
  • Check for inconsistencies between single and plural arguments.
  • Check for multiple unordered placeholders.
  • Check that the translatable string itself is not empty

Source: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/eccb1f721f95fdcf5c2e383340aa4b094c0317ad/WordPress/Sniffs/WP/I18nSniff.php#L36-L59

Let's determine whether it makes sense to port some of these over to WP-CLI.

@swissspidy
Copy link
Member Author

Fixed by #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant