Factor directory iterator as a trait #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on it. and make extension generic so that test (<extension> === 'php') can be overriden if needed.
drzraf
changed the title
|
That would need the same change for the JS extractor to make things DRY. |
swissspidy
reviewed
Jul 25, 2018
src/IterableCodeExtractor.php
Outdated
| private static $dir = ''; | ||
|
|
||
| /** | ||
| * {@inheritdoc} |
There was a problem hiding this comment.
I'd use the docs from the ExtractorInterface here as there's nothing to inherit from otherwise.
Plus, we could describe the possible options a bit better. Perhaps the way WordPress core does it: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#1-1-parameters-that-are-arrays
swissspidy
reviewed
Jul 25, 2018
src/IterableCodeExtractor.php
Outdated
| * | ||
| * @param string $dir Root path to start the recursive traversal in. | ||
| * @param Translations $translations The translations instance to append the new translations. | ||
| * @param array $options |
There was a problem hiding this comment.
As noted above, we could describe the possible options a bit better. Perhaps the way WordPress core does it: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#1-1-parameters-that-are-arrays
schlessera
approved these changes
Jul 31, 2018
|
Thanks for the pull-request, @drzraf ! |
schlessera
added a commit
that referenced
this pull request
Jan 6, 2022
Factor directory iterator as a trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor directory iterator as a trait so that other extractor can rely on it and make extension generic so that test (
<extension>=== 'php') can be overridden if needed.