Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces WP_Query to WC_Product_Query in Product connections #37

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Uses WC_Product_Query instead of WP_Query. Adds support for custom Product data stores, however pagination functionality will to still have to filtered in order to work properly.

  • WP_Query => WC_Product_Query

Implements ProductTypesEnum for resolve product type. values are filterable through the graphql_product_types_enum hook.

  • ProductTypesEnum type
  • Products connections where args type, typeIn, typeNotIn updated
  • Product type field type updated
  • ProductVariation type field type updated

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System:

WordPress Version:

@kidunot89 kidunot89 added the enhancement New feature or request label Apr 23, 2019
@kidunot89 kidunot89 self-assigned this Apr 23, 2019
@kidunot89 kidunot89 merged commit d03e28b into bugfix/cpt-pagination Apr 24, 2019
@kidunot89 kidunot89 mentioned this pull request Apr 25, 2019
@renatonascalves renatonascalves deleted the topic/wp-query-to-wc-product-query branch May 4, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant