-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/444 - Adding entry point for querying user roles #463
Conversation
Sooooo, I ran |
@CodeProKid try running:
|
@jasonbahl looks like build is passing now. Wanna take a look when you get a chance? |
composer.lock
Outdated
@@ -7376,4 +7376,4 @@ | |||
"prefer-lowest": false, | |||
"platform": [], | |||
"platform-dev": [] | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my IDE has been doing that on some files. I'll check it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeProKid, one tiny thing but this looks great 👏
src/Data/DataSource.php
Outdated
|
||
} | ||
|
||
public static function resolve_user_role_connection( $source, array $args, AppContext $context, ResolveInfo $info ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a doc block here
I'm pulling this locally to check some things out as well. |
@hughdevore & @jasonbahl this should be fixed up now 👍 |
@CodeProKid good work. got this merged 😄 |
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
Implements queries for User Roles
Does this close any currently open issues?
closes #444
Any relevant logs, error output, GraphiQL screenshots, etc?
Example query for getting all roles:
Example query for getting info on a single role:
Any other comments?
There are some new autoloader files in here that weren't previously in the repo. I don't think I did anything weird to have these generated, not sure if it's just because I'm on a different version of composer or what though.
Where has this been tested?
Operating System: …
WordPress Version: 4.9.6