Bug/#598 term search doesn't include child terms in results #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v0.1.2
- update version number in wp-graphql.php
…to release/v0.1.3
…on' into release/v0.1.3
The filter was not firing after the type registry changes because the fields definition was wrapped in a closure and could only be modified or filtered inside the closure.
- This adjusts the PostObjectConnectionResolver and the TermObjectConnectionResolver to ensure that search queries include terms that don't have the parent set to 0.
Codecov Report
@@ Coverage Diff @@
## develop #599 +/- ##
===========================================
- Coverage 59.28% 59.26% -0.02%
===========================================
Files 107 107
Lines 6641 6646 +5
===========================================
+ Hits 3937 3939 +2
- Misses 2704 2707 +3
Continue to review full report at Codecov.
|
|
@CodeProKid I also opened a PR for this straight to the release branch |
CodeProKid
approved these changes
Dec 4, 2018
|
@jasonbahl can I merge this, or should we wait until we clarify the path forward on #597 |
|
@CodeProKid ah, jumped the gun. . .saw it was approved and merged before I saw your message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terms:
Before this PR:
After this PR:
