[wpimath] Make controllers and some trajectory classes constexpr #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
wpimath-make-controllers-and-some-trajectory-classes-constexpr
branch
5 times, most recently
from
9410c23 to
7f2837a
Compare
PeterJohnson
reviewed
Nov 5, 2024
| @@ -66,7 +109,14 @@ class WPILIB_DLLEXPORT Trajectory { | |||
| * | |||
| * @throws std::invalid_argument if the vector of states is empty. | |||
| */ | |||
| explicit Trajectory(const std::vector<State>& states); | |||
| explicit Trajectory(const std::vector<State>& states) : m_states(states) { | |||
There was a problem hiding this comment.
These were moved to the header but are not constexpr?
There was a problem hiding this comment.
They originally were, but we need GCC 12 for constexpr std::vector, which caused CI to fail. Bumping our RPi OS version to bookworm would fix that.
In any case, the functions are short enough to be inlined.
|
Does this have a measurable effect on build times? |
calcmogul
force-pushed
the
wpimath-make-controllers-and-some-trajectory-classes-constexpr
branch
from
7f2837a to
99bd370
Compare
calcmogul
force-pushed
the
wpimath-make-controllers-and-some-trajectory-classes-constexpr
branch
from
99bd370 to
e3a68eb
Compare
|
Seems negligible. I just did a clean build with ccache cleared. main: this PR: (I have to skip failed compilations cuz cscore can't compile against my machine's version of OpenCV Java due to class file incompatibility.) |
PeterJohnson
approved these changes
Nov 7, 2024
calcmogul
deleted the
wpimath-make-controllers-and-some-trajectory-classes-constexpr
branch
sciencewhiz
added a commit
to sciencewhiz/frc-docs
that referenced
this pull request
Nov 8, 2024
sciencewhiz
added a commit
to wpilibsuite/frc-docs
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.