Collapse preview by default

[codyjames]

@reganlawton This is what I was thinking. Basically, you'd semi-collapse previews by default. This keeps the CP condensed but still gives the author a sense that the embed worked.

This would remove the need for the "Previews hidden by default" setting, I think, but I didn't want to strip all of that out just yet.

No worries if you prefer your solution better, just thought I'd give this one a try.

Here is a screenshot of the default state looks like:

[reganlawton]

Could you maybe edit to have a setting option that gives you an choose? Collapsed or cropped collapsed? That way everyone is happy COD I think you make a good point

[codyjames]

Sure, I can work on that if you think you’ll merge it in!

[reganlawton]

I mean having both style options are useful

[codyjames]

@reganlawton I've accounted for the fully hidden option. By default, it does the semi-collapsed view, but if you set that setting it'll do a full collapse.

[reganlawton]

@codyjames your screenshot doesn't quite match up to your code is all the code commited?

[codyjames]

@reganlawton Made some tweaks to this. Can you check it out?

If you are still not seeing the right thing can you attach some screenshots so I can troubleshoot? Also, let me know which browser it may be happening in.

[reganlawton]

Yeah can do I'll try get to a review today.

[reganlawton]

@codyjames I have not forgotten!!!

[reganlawton]

This is out via a setting