Needed Development: Clean up exception handling when S4U makes it possible #7
Labels
Milestone
Comments
|
Clean SimGrid exceptions are used for communication. A few xbt_ex instances still occur, and will need to be removed eventually, but they are pretty minimal. Still worth keeping this issue open though. |
|
At this point the only use of xbt_ex in the code are when catching exception on Actor::kill(), Actor::join(), Actor::suspend(), and Actor::resume(). After writing a few example programs to see what exceptions would be generated by S4U for these (since documentation is sparse), the conclusion is that SimGrid is still does not have clean S4U exceptions for everything. So I am postponing this issue to the 1.4 release. |
julien-monniot
pushed a commit
to julien-monniot/wrench
that referenced
this issue
Feb 7, 2023
# This is the 1st commit message: Adding skeleton for a CompoundStorageService (heavily inspired by SimpleStorageService) # This is the commit message wrench-project#2: CompoundStorageService starts (working service state, even though it doesn't do anything yet) # This is the commit message wrench-project#3: CompoundStorageService : adding method to get all internal services ; FileLocation : adding two methodes to update storage service and mount point of an existing FileLocation ; BareMetalCompoundService: adding a very simple (and dirty) code block to automatically replace a CompoundStorageService in a Read or Write file Action with its first (or only) internal concrete storage service ; BatchComputeService: just tinkering with comments in order to find an appropriate place to put the same kind of code block as in BareMetalComputeService # This is the commit message wrench-project#4: Fixing CompoundStorageService after last merge from master: manually adding a LogicalFilesystem on /dev/null, updating the use od StorageService constructor and adding proper messagepayloadsize and property values init. # This is the commit message wrench-project#5: New scheduler (copy of ConservativeBackfilling, but storage-aware) # This is the commit message wrench-project#6: Functional test added for CompoundStorageService. Also overriding some parent methods in CSS for coherency, and putting in place a few safeguards. Test is still incomplete (but passing at the moment) # This is the commit message wrench-project#7: Updating CompoundStorageService so that it can safely discard Read/Write/Delete/Lookup/Copy message requests (it answers with a failure cause stating that the feature in not available) ; updated test accordingly # This is the commit message wrench-project#8: Fixing a small bug in the new test setup # This is the commit message wrench-project#9: Cleaning up batch scheduler for storage, adding some logging in CompoundStorageService and cleaning up functionnal test # This is the commit message wrench-project#10: Minor clean-up and comments # This is the commit message wrench-project#11: First (probably still broken) implementation of message transfer inside the CSS -> tested for FileCopy and FileRead, and it seems to work.. # This is the commit message wrench-project#12: Minor fix to the Storage selection callback in CSS # This is the commit message wrench-project#13: Working on tests for message transfers in CSS (currently there's a crash by action deadlock in the test simulation, but several fixes already implemented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One day, S4U will provide a clean exception hierarchy, at which point we'll nee to revisit/fix the low-level S4U calls in WRENCH so as to clean up and robustify our own code.
Simple objective: no longer have any use for the xbt_ex class/structure, only simgrid::*Exception classes.
The text was updated successfully, but these errors were encountered: