Reduce computational patch size for intermediate domain for vertical nesting #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting TYPE: bug fix KEYWORDS: vertical refinement, intermediate domain, patch SOURCE: internal DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes. The vertical refinement option rebalances the fine grid to account for the horizontal and vertical interpolation. The intermediate domain value are coupled with total column pressure. When the allocated but not initialized portions of the patch are part of the computations, floating point errors show up when using the FPE traps. The solution is to restrict the patch dimensions to be entirely enclosed with the domain dimensions (for the intermediate domain). LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list) external/RSL_LITE/module_dm.F TESTS CONDUCTED: Explicitly state if a WTF and or other tests were run, or are pending. For more complicated changes please be explicit! 1) With the mods, the code successfully runs through several time steps with the FPE flags activated. 2) TO DO: standard WTF 3) TO DO: compare results from modified version to pristine master, they should be the same
modified: module_dm.F
mkavulich
approved these changes
Nov 11, 2016
dmey
pushed a commit
to TEB-model/wrf-teb
that referenced
this pull request
Mar 31, 2020
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 9, 2022
Code compiled and an old case ran on my end. Thanks for finding the pi change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: vertical refinement, intermediate domain, patch
SOURCE: internal
DESCRIPTION OF CHANGES:
The vertical refinement option rebalances the fine grid to
account for the horizontal and vertical interpolation. The
intermediate domain value are coupled with total column pressure.
When the allocated (but initialized to zero) portions of the patch
are part of the computations, floating point errors show up
when using the FPE traps. These values are never used, but the
uninitialized values throw FPEs when we are doing division.
The solution is to require that the computations be entirely
enclosed with the more restrictive of either the patch or domain dimensions
(for the intermediate domain, "patch" and "domain" sizes are not
as intuitive as on a parent or child domain).
LIST OF MODIFIED FILES:
external/RSL_LITE/module_dm.F
TESTS CONDUCTED:
steps with the FPE flags activated, and the code was not able to
do so without these mods.
restricted index computations are INDEED giving the same results). This
is a comparison of the 1798 regression tests (with and without vertical
nesting).
I WILL REMOVE THE FOLLOWING IN THE FINAL COMMIT: