-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Geotrellis #79
Conversation
...ala/org/globalforestwatch/summarystats/annualupdate_minimal/AnnualUpdateMinimalSummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/carbonflux/CarbonFluxGridSources.scala
Show resolved
Hide resolved
...n/scala/org/globalforestwatch/summarystats/carbon_sensitivity/CarbonSensitivitySummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/annualupdate/AnnualUpdateSummary.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/annualupdate/AnnualUpdateSummary.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/carbonflux/CarbonFluxSummary.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/carbonflux/CarbonFluxSummary.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/globalforestwatch/summarystats/carbon_sensitivity/CarbonSensitivitySummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/treecoverloss/TreeLossSummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/firealerts/FireAlertsSummary.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/firealerts/FireAlertsSummary.scala
Outdated
Show resolved
Hide resolved
val tile = source.synchronized { | ||
source.read(window).get.tile.band(0) | ||
layoutSource.read(windowKey).get.band(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Usage of get on optional type.
...ala/org/globalforestwatch/summarystats/carbon_sensitivity/CarbonSensitivityGridSources.scala
Show resolved
Hide resolved
...ala/org/globalforestwatch/summarystats/annualupdate_minimal/AnnualUpdateMinimalSummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/gladalerts/GladAlertsSummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/gladalerts/GladAlertsGridSources.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/treecoverloss/TreeLossSummary.scala
Show resolved
Hide resolved
src/main/scala/org/globalforestwatch/summarystats/gladalerts/GladAlertsSummary.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Please check if you can update scala to 2.12 as well and also update to the latest hadoop, spark and EMR version.
With geotrellis updated we should be able to get grid of the cropWindow
function which was a poor hack anyways
https://github.com/wri/gfw_forest_loss_geotrellis/pull/79/files#diff-6923804677e730eecbd92506b9516a84f0ef44e050a0ec9134e05af8393b175cL257-L278
It was due to this issue locationtech/geotrellis#2918
Just to confirm, can we now use the requester-pays option for S3 reads? I didn't see any config changes.
src/main/scala/org/globalforestwatch/summarystats/gladalerts/GladAlertsRDD.scala
Show resolved
Hide resolved
…eading nbits=1 layers in geotrellis
To confirm is the requester pays option handled? If yes how? |
@thomas-maschler oh sorry, somehow lost track of those comments when going back. Will just quickly fix those before merging. |
Updated Geotrellis to latest release, 3.5.0.
The main significant changes this entailed:
Also changed to read using GDAL. This has a few caveats: