Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable keepalive on TCP connections #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luke-jr
Copy link

@luke-jr luke-jr commented Nov 20, 2011

This helps a lot.

@wrog
Copy link
Owner

wrog commented Apr 2, 2013

Is there something in particular that this helps with?

Seems like it should be an option and probably a connection option, not just a server option. The problem is keep-alive does cause connections to get dropped when they otherwise wouldn't, i.e., if there's a temporary network outage during which nothing's actually getting transmitted on a connection a keep-alive during that outage would kill the connection, whereas without the keep-aliave if the network came back before any actual packets get sent, it'll be as if there'd never been an outage. And it seems like this would particularly be a problem for places like LambdaMOO where people typically stay idle for very long periods of time.

Should probably also have a way to mess with tcp_keepalive_time and tcp_keepalive_intvl (default for tcp_keepalive_time on my system is 2 hours, which I suspect would make it useless for any application that doesn't customize)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants