Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Siddhi Extensions Installer Backend #1785

Merged
merged 8 commits into from
Feb 14, 2020

Conversation

senthuran16
Copy link
Member

@senthuran16 senthuran16 commented Feb 11, 2020

Purpose

$subject.

  • All extension information have to be added to extensionDependencies.json.
  • Documentation (for extension developers) has to be added.

Goals

Providing mechanism to install/uninstall dependencies related to Siddhi Extensions, in an automated manner.

Related Issues

wso2/streaming-integrator#70

Security checks

Related PRs

wso2/streaming-integrator-tooling#51

@senthuran16 senthuran16 changed the title Add Siddhi Extensions Installer Add Siddhi Extensions Installer Backend Feb 11, 2020
public static Map<String, ExtensionConfig> loadAllExtensionConfigs(String configFileLocation)
throws ExtensionsInstallerException {
Gson gson = new Gson();
Type mapType = new TypeToken<Map<String, ExtensionConfig>>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary line brake

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #1859

private boolean deleteMatchingJars(String lookupRegex, String directoryPath) {
boolean allJarsDeleted = false;
try {
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #1859

try {
Files.deleteIfExists(jarFile);
} catch (IOException e) {
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #1859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants