Fix Early Throttling by Adding Timestamp Check to Throttling Logic and Refine Throttling Related Unit Tests #12696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the TM receives events, it currently places them into the current bucket without considering the original event generation timestamp. As a result, events generated before downtime are counted toward the active throttling period, leading to early throttling.
Fix
This PR adds a timestamp check to the throttling logic to ensure that each event is evaluated based on its generation time. By incorporating this timestamp, events generated before downtime are dropped, preventing them from causing premature throttling when a DC resumes operation.