Overview steps UI #7273
Merged
Overview steps UI #7273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
menakaj
reviewed
Oct 1, 2019
| <StepLabel style={{ position: 'relative' }}> | ||
| <Box className={classes.box}> | ||
| <Typography variant='h6'> | ||
| Created |
| {lifecycleState === 'Created' && ( | ||
| <Box className={classes.box}> | ||
| <Typography variant='h6'> | ||
| Published |
| <StepLabel style={{ position: 'relative' }} > | ||
| <Box p={2} bgcolor='white' width='377px' borderColor='grey.500' borderLeft='0' borderRight='0' > | ||
| <Typography variant='h10'> | ||
| Requirements |
| <CloseIcon className={classes.iconFalse} /> | ||
| )} | ||
|
|
||
| <Typography variant='caption'>Endpoint</Typography> |
There was a problem hiding this comment.
Should be Endpoints. Add i18n as well
There was a problem hiding this comment.
It should be Endpoint. In order to satisfy the basic requirement you only need to provide one endpoint.
Added i18n.
| ) : ( | ||
| <CloseIcon className={classes.iconFalse} /> | ||
| )} | ||
| <Typography variant='caption'>Business plans</Typography> |
| {lifecycleState === 'Published' && ( | ||
| <Box bgcolor='primary.main' p={2} m={2} border={1}> | ||
| <Typography variant='h6'> | ||
| Published |
kavishkafernando
force-pushed
the
master-kavi
branch
from
c1b623f to
85f5c7b
Compare
kavishkafernando
force-pushed
the
master-kavi
branch
from
4f07fc0 to
d177e0b
Compare
menakaj
approved these changes
Oct 3, 2019
tmkasun
reviewed
Oct 3, 2019
| */ | ||
| function updateLCStateOfAPI() { | ||
| setUpdating(true); | ||
| const promisedUpdate = restApi.updateLcState(api.id, 'Publish'); |
There was a problem hiding this comment.
Shall we use api.publish() the method instead of calling REST api directly
tmkasun
reviewed
Oct 3, 2019
| console.log(errorResponse); | ||
| Alert.error(JSON.stringify(errorResponse.message)); | ||
| }) | ||
| .finally(() => setUpdating(false)); |
There was a problem hiding this comment.
Shall we move this final call to updateAPI() promise
wso2-jenkins-bot
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the step for API creation in the Overview page.