Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modified (simplified) error messages for api create form. #7399

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Add modified (simplified) error messages for api create form. #7399

merged 2 commits into from
Oct 9, 2019

Conversation

menakaj
Copy link
Contributor

@menakaj menakaj commented Oct 9, 2019

Fixes wso2/product-apim#5541 (1 and 2)

64774176-51171a00-d571-11e9-8d34-cb121386f5f6

  1. The error message should be more user-friendly (without a regex preferably)
  2. "value" should be fixed

Screenshot (14)

});
return tmpErrors;
}),
apiContext: Joi.string().regex(/^[a-zA-Z0-9{}/]{1,50}$/).required().error((errors) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to change the regex used to validate apiContext. This is introduced as fix for wso2/product-apim#5848

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a67110b

@menakaj menakaj merged commit f1e22a6 into wso2:master Oct 9, 2019
wso2-jenkins-bot added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Product create UI issues
3 participants