Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't merge] Add component yaml configuration definition with connection env renaming guide #1684
base: dev
Are you sure you want to change the base?
[Don't merge] Add component yaml configuration definition with connection env renaming guide #1684
Changes from 2 commits
a81bf62
0121d32
fe29e02
272bce8
b09a03f
28837ac
da89590
8dd4a11
31851a2
5ec4652
5371696
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say "The source of the environment variable value."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say "The name of the Choreo connection to reference the value from."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
"The Choreo connection configuration key to reference the value from. For details on available keys, see Consume a service through a connection or the inline developer guide."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
When an environment variable value is specified using
connectionRef
, the connection's environment variable is renamed to the environment variable name defined in theconfiguration
section. For example, in the samplecomponent.yaml
file given above, theCHOREO_HR_CONNECTION_SERVICEURL
variable in thehr-connection
is renamed toHR_SERVICE_URL
.