Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Introduce new icons and logos related to custom authentication feature #7322

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

Shenali-SJ
Copy link
Contributor

@Shenali-SJ Shenali-SJ commented Jan 18, 2025

Purpose

This PR introduces new logos and icons associated with the new custom authentication feature.

The following are the introduced icons.

  1. Custom Authentication - A new connection
image
  1. External (Federated) Custom Authentication - Type of custom authentication
image
  1. Internal User Authentication - Type of custom authentication
image
  1. 2FA Authentication - Type of custom authentication
image

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add license header to each svg file.

Also add the changeset.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (9ecf97c) to head (d0e1325).
Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7322   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      205      205           
=======================================
  Hits          324      324           
  Misses        575      575           
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Shenali-SJ Shenali-SJ force-pushed the custom-authentication-icons branch from f2c4791 to d0e1325 Compare January 19, 2025 13:03
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@pavinduLakshan pavinduLakshan merged commit 7679e4b into wso2:master Jan 20, 2025
11 checks passed
@Shenali-SJ Shenali-SJ mentioned this pull request Jan 22, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants