[CircleCI] Add configurable number of builds to settings #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senorprogrammer
requested changes
Nov 18, 2020
modules/circleci/settings.go
Outdated
| @@ -15,15 +15,17 @@ const ( | |||
| type Settings struct { | |||
| common *cfg.Common | |||
|
|
|||
| apiKey string `help:"Your CircleCI API token."` | |||
| apiKey string `help:"Your CircleCI API token."` | |||
| buildNumber int `help:"The number of build, 10 by default"` | |||
There was a problem hiding this comment.
I would suggest numberOfBuilds instead. buildNumber could be misconstrued as a specific build number (ie. 453) rather than a quantity.
There was a problem hiding this comment.
Agreed. Adressed this in 5b17ddf, thanks for the review.
Not sure why the linting fails in https://github.com/wtfutil/wtf/pull/1025/checks?check_run_id=1421195730 though.
|
Looks great to me. One small request and then I'm happy to merge it. |
Closed
|
That linting error is strange, and I'm going to ignore it. |
|
Good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to set the number of builds in the config