Fix documentation for logging module #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, the name of the widget should be changed from logging to logger too. |
|
I will submit a patch to this with the change in widget name later today |
|
I tried out the new logging module, works well. Would be good to mention that if enabled=false in the config, you can still log, it just doesn't display the widget. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6acf177
changed the name of the module but inconsistencies still remain in the documentation and in the widget names.
What problem does this solve?
Fix inconsistencies in naming and documentation for the logging/logger module
Is this related to an existing Issue? If so, which one?
No open issues on this