Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for configuring the Gerrit module #248

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

anandsudhir
Copy link
Member

@anandsudhir anandsudhir commented Jul 18, 2018

The current documentation incorrectly mentions the gerrit domain is optional. The code however requires this to be set.

This change fixes the documentation

@senorprogrammer
Copy link
Collaborator

Can you explain to me why these changes are necessary?

@anandsudhir
Copy link
Member Author

I was just being lazy and didn't add a description. I have updated now though :)

@senorprogrammer
Copy link
Collaborator

Thanks

@senorprogrammer senorprogrammer merged commit c235d8a into wtfutil:master Jul 18, 2018
@anandsudhir anandsudhir deleted the fix-gerrit-documentation branch July 24, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants