Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTF-730 Fix missing color key config error #738

Merged
merged 8 commits into from
Nov 9, 2019

Conversation

senorprogrammer
Copy link
Collaborator

@senorprogrammer senorprogrammer commented Nov 7, 2019

Redesigns the color configuration to provide a set of logical defaults, the ability to over-ride globally, and the ability to over-ride locally per module.

Also fixes #718 and fixes #730 by allowing the global config to not have a colors configuration key.

Signed-off-by: Chris Cummer [email protected]

@senorprogrammer senorprogrammer force-pushed the WTF-730-dynamic-resize branch 2 times, most recently from 0d8fc0e to df7cabe Compare November 7, 2019 11:31
Users can now set a `subheading` color in their config to change the
color of subheadings in widget display.

Defaults to `red`.

Signed-off-by: Chris Cummer <[email protected]>
@senorprogrammer senorprogrammer force-pushed the WTF-730-dynamic-resize branch 4 times, most recently from f88262b to 1d67adb Compare November 7, 2019 12:03
Clean up missing color config changes not addressed in earlier commits.

Signed-off-by: Chris Cummer <[email protected]>
Signed-off-by: Chris Cummer <[email protected]>
@senorprogrammer senorprogrammer merged commit 200dbcc into master Nov 9, 2019
@ptxmac
Copy link

ptxmac commented Nov 9, 2019

I think you closed the wrong issues - #718 and #730 had nothing to do with the colors key

@senorprogrammer senorprogrammer deleted the WTF-730-dynamic-resize branch November 27, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic resizing no longer works Panic after upgrade
2 participants