Close #876 - fix todo modal editing feeling slow #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wtfutil#876. The modal shown when editing todos was feeling slow to start It required an additional hit of `Enter` to show the modal. This commit fixes it by queueing a `Draw` update - so now the modal feels fast to show. Tests: * ran `make test` * tested locally with a todo list
aeter
force-pushed
the
feature/fix-todo-modal-slowness
branch
from
ea78904 to
f051bdb
Compare
|
Thank you for this. This PR will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #876. The modal shown when editing todos was feeling slow to show - there was required an additional hit of
Enterto show the modal.This commit queues a
Drawupdate in theupdateSelectedfunction (similarly to thenewItemfunction) - so now the modal feels fast to show.Tests:
make test