Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-grpc: Fix syntax for Scala 3 #2193

Merged
merged 2 commits into from
May 27, 2022
Merged

airframe-grpc: Fix syntax for Scala 3 #2193

merged 2 commits into from
May 27, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented May 27, 2022

  • Fix for Scala 3 syntax

TODO in another PR

@xerial xerial added this to the Scala 3 milestone May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2193 (51a8d69) into master (1b94fa6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   82.57%   82.57%   -0.01%     
==========================================
  Files         312      312              
  Lines       12352    12353       +1     
  Branches      790      790              
==========================================
  Hits        10200    10200              
- Misses       2152     2153       +1     
Impacted Files Coverage Δ
...in/scala/wvlet/airframe/http/grpc/GrpcServer.scala 63.33% <0.00%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b94fa6...51a8d69. Read the comment docs.

@xerial
Copy link
Member Author

xerial commented May 27, 2022

Filed follow-up tasks in #2194

@xerial
Copy link
Member Author

xerial commented May 27, 2022

This PR only fixes Scala 3 incompatible syntaxes

@xerial xerial merged commit ee60277 into master May 27, 2022
@xerial xerial deleted the grpc-scala3 branch June 2, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant