airframe-sql: Implement outputAttributes of Unnest #2618
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
+ Coverage 82.00% 82.02% +0.02%
==========================================
Files 333 333
Lines 13869 13870 +1
Branches 2189 2195 +6
==========================================
+ Hits 11373 11377 +4
+ Misses 2496 2493 -3
Continue to review full report at Codecov.
|
| override def inputAttributes: Seq[Attribute] = Seq.empty // TODO | ||
| override def outputAttributes: Seq[Attribute] = Seq.empty // TODO | ||
| override def children: Seq[LogicalPlan] = Seq.empty | ||
| override def inputAttributes: Seq[Attribute] = Seq.empty // TODO |
| override def inputAttributes: Seq[Attribute] = Seq.empty // TODO | ||
| override def outputAttributes: Seq[Attribute] = { | ||
| columns.map { | ||
| case a: ArrayConstructor => SingleColumn(MultiColumn(a.values, None), None, None, a.nodeLocation) |
There was a problem hiding this comment.
Not sure whether we should retain all of the input expressions. I think if we can associate the column name for each ArrayConstructor, we can discard Literal values here except the other Attributes (Id, ResolvedAttributes, etc.).
There was a problem hiding this comment.
That's right. I think the same thing can be applied to SELECT FROM VALUES.
There was a problem hiding this comment.
It's ok to merge. We can fix the behavior later.
No description provided.