Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-rx-html: Support implicit convertion to RxElement with import wvlet.airframe.rx.html.all.* #3008

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Jun 12, 2023

For rendering DOM elements, two wildcard import was necessary:

import wvlet.airframe.rx.html.*
import wvlet.airframe.rx.html.all.*

With this PR, only all.* import will be required

@xerial xerial enabled auto-merge (squash) June 12, 2023 16:48
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #3008 (922ccc1) into master (70012e8) will increase coverage by 0.00%.
The diff coverage is 87.50%.

❗ Current head 922ccc1 differs from pull request most recent head 6810b8e. Consider uploading reports for the commit 6810b8e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3008   +/-   ##
=======================================
  Coverage   82.83%   82.84%           
=======================================
  Files         348      349    +1     
  Lines       14619    14620    +1     
  Branches     2419     2373   -46     
=======================================
+ Hits        12110    12112    +2     
+ Misses       2509     2508    -1     
Impacted Files Coverage Δ
...la/wvlet/airframe/rx/html/RxEmbeddingSupport.scala 87.09% <87.09%> (ø)
...rc/main/scala/wvlet/airframe/rx/html/package.scala 91.30% <87.50%> (+2.62%) ⬆️
...rc/main/scala/wvlet/airframe/rx/html/SvgTags.scala 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70012e8...6810b8e. Read the comment docs.

@xerial xerial merged commit 2e815d2 into master Jun 12, 2023
@xerial xerial deleted the svg-title branch June 12, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airframe-rx-html: SVG title tag should not be an attribute
1 participant